RE: [PATCH BlueZ 5/5] AVRCP: Add handler for browsing pdu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx]
> Sent: Wednesday, July 18, 2012 4:35 PM
> To: Vani-dineshbhai PATEL X
> Cc: User Name; Lucas De Marchi; Joohi RASTOGI; Vani
> Subject: Re: [PATCH BlueZ 5/5] AVRCP: Add handler for browsing pdu
> 
> Hi Vani,
> 
> On Wed, Jul 18, 2012 at 1:49 PM, Vani-dineshbhai PATEL X
> <vani.patel@xxxxxxxxxxxxxx> wrote:
> >> This is probably not necessary as the header should only be needed
> >> inside avrcp.c you don't need to make it public.
> >>
> > AVRCP_BROWSING_HEADER_LENGTH is being used in
> session_browsing_cb function.
> > Avrcp_browsing_header is not used. I will remove it from here.
> 
> But why you are using AVRCP_BROWSING_HEADER_LENGTH inside avctp.c?
> There you should only parse the avctp header not its contents/pdu.
> 
Yes, you are correct in pointing that out. I need to remove that. I will do the needful.
> --
> Luiz Augusto von Dentz

Thanks & Regards,
Vani Patel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux