Re: [PATCH 1/7] Bluetooth: debug: Print l2cap refcount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Tue, Jul 10, 2012 at 03:33:33PM -0300, Gustavo Padovan wrote:
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> > ---
> >  include/net/bluetooth/l2cap.h |    6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> > index d80e3f0..dfe9374 100644
> > --- a/include/net/bluetooth/l2cap.h
> > +++ b/include/net/bluetooth/l2cap.h
> > @@ -672,11 +672,17 @@ enum {
> >  
> >  static inline void l2cap_chan_hold(struct l2cap_chan *c)
> >  {
> > +	BT_DBG("chan %p refcnt %d -> %d", c, atomic_read(&c->refcnt),
> > +	       atomic_read(&c->refcnt) + 1);
> > +
> 
> We don't really need to call atomic_read() twice read. Just print the new
> value and the log reader has to figure it out.

The code looks better if I print original refcnt in a case chan_put and
also for kref cases with amp_mgr. I will send patches shortly.

Best regards 
Andrei Emeltchenko 
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux