Re: [PATCH BlueZ 01/12] storage: Store address type in "names" file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Johan Hedberg <johan.hedberg@xxxxxxxxx>
Date: Mon, 2 Jul 2012 14:25:50 +0300

> Hi Paulo,
> 
> On Thu, Jun 14, 2012, Paulo Alcantara wrote:
> > +	uint8_t bdaddr_type;
> >  
> >  	idev = g_new0(struct input_device, 1);
> >  	adapter_get_address(adapter, &idev->src);
> > -	device_get_address(device, &idev->dst, NULL);
> > +	device_get_address(device, &idev->dst, &bdaddr_type);
> 
> I think it'd be clearer to call this dst_type (since it matches dst_addr
> and not src_addr). Could you also change this in all other places the
> variable naming occurs in your patches.

Yeah, indeed. I'll send a v2 of this patchset with the proposed changes.

Thanks!


		Paulo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux