Hi Mikel, On Tue, Jun 19, 2012, Mikel Astiz wrote: > From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> > > Using sock_error() here to check the status of the socket is wrong > because it resets sk->sk_err to zero. For RFCOMM sockets, this means the > disconnect reason is not exposed to userland in the socket options. > > Signed-off-by: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> > --- > This a second attempt to expose ACL disconnect reason to userland, as proposed first in "[RFC v0] Bluetooth: mgmt: Add device disconnect reason". > > The motivation behind was explained in the userspace patchset "[RFC BlueZ v0 0/5] ACL disconnect reason". > > This second approach focuses on RFCOMM sockets given that L2CAP is already exposing such information. > > net/bluetooth/af_bluetooth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c > index f7db579..4799338 100644 > --- a/net/bluetooth/af_bluetooth.c > +++ b/net/bluetooth/af_bluetooth.c > @@ -313,7 +313,7 @@ int bt_sock_stream_recvmsg(struct kiocb *iocb, struct socket *sock, > if (copied >= target) > break; > > - err = sock_error(sk); > + err = sk->sk_err; > if (err) > break; > if (sk->sk_shutdown & RCV_SHUTDOWN) Looking at the implementation of sock_error (include/net/sock.h) This should be: err = -sk->sk_err; However, is this really needed if the error is returned for the write() or read() that triggers it (through errno). And in the case of POLLHUP/POLLERR there wont be any write/read that could clear the error so you should be able to read it with getsockopt just fine. Am I missing something? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
