On Mon, 2012-06-25 at 10:20 +0100, David Laight wrote: > > > > Fine with me, though FWIW that not only doesn't use > > > > __constant_cpu_to_le16() but actually swaps the non-constant value. > > > > > > Don't see what point you are trying to make here. Swapping the value > > > from the actual command structure is always fine with me. > > > > The point is that the result of swapping a constant value is just > > another constant value, whereas the fix in mainline swaps a value from > > memory. Not a big deal. > > Surely, but surely, the definition of cpu_to_le16() uses > gcc 'magic' to determine that the argument is a constant > and then automatically selects the 'constant' form. It can only do that if the argument is constant in the first place though. :) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
