Hi Lucas, On Tue, Jun 19, 2012, Lucas De Marchi wrote: > >>>> Would it be interesting to add this option to acinclude.m4? Or does it > >>>> generate too much noise? > >>> > >>> It generates few warnings. Depending on the acceptance of this patch, > >>> I could fix bluez as a whole and add -Wshadow to acinclude.m4. > >> > >> Actually, I had a partial build here. Ignore the previous answer, it > >> generates a lot of warnings. > >> > > > > If we're not going to enable -Wshadow by default, does it make sense > > to apply this patch? Who is going to check if no new shadow warnings > > are being inserted in new commits? > > I'm all for doing the following: > > 1) Fix all the places with shadow variables > 2) Add -Wshadow to the warning flags > > There are lots of them. Agreed. This could be one of the targets before releasing BlueZ 5.0. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
