RE: [PATCH hcidump 2/2] AVRCP: Add support for Addressed Player Changed event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz, 

One important comment and one cosmetic.

> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> 
> ---
>  parser/avrcp.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/parser/avrcp.c b/parser/avrcp.c
> index 0f2f1e6..6fa3742 100644
> --- a/parser/avrcp.c
> +++ b/parser/avrcp.c
> @@ -1107,6 +1107,7 @@ static void avrcp_register_notification_dump(int level, struct frame *frm,
>                                                  uint8_t ctype, uint16_t len)
>  {
>          uint8_t event, status;
> +       uint16_t uid;
>          uint32_t interval;
>          uint64_t id;
> 
> @@ -1202,6 +1203,15 @@ response:
>                  status = get_u8(frm) & 0x7F;
>                  printf("Volume: %.2f%% (%d/127)\n", status/1.27, status);
>                  break;
> +       case AVRCP_EVENT_ADDRESSED_PLAYER_CHANGED:
> +               uid = get_u16(frm);
> +               printf("PlayerID: 0x%04x", uid);

uid? You can use "id" to replace "uid" in this place.
ID can be decimal.

> +
> +               p_indent(level, frm);
> +
> +               uid = get_u16(frm);
> +               printf("UID: 0x%04x", uid);
> +               break;

This is not "UID". This is "UID Counter".

>          }
>  }
> 
> --
> 1.7.10.2

Regards / Pozdrawiam
-------------------------------------------------------------------------------------------------------------
Michał Łabędzki
ASCII: Michal Labedzki
e-mail: michal.labedzki@xxxxxxxxx
office communicator: michal.labedzki@xxxxxxxxx
location: Poland, Wrocław, Legnicka 55F
room: 315
phone: +48 717 740 340
---
Tieto Corporation / Tieto Poland
http://www.tieto.com / http://www.tieto.pl
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux