[PATCH obexd 5/7] Fix dead assignments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Values stored are never read.
---
 client/pbap.c        |    2 +-
 plugins/filesystem.c |    2 +-
 plugins/pbap.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/pbap.c b/client/pbap.c
index 4428c14..48dbac1 100644
--- a/client/pbap.c
+++ b/client/pbap.c
@@ -520,7 +520,7 @@ static DBusMessage *pull_vcard_listing(struct pbap_data *pbap,
 	p = fill_apparam(p, &count, MAXLISTCOUNT_TAG, MAXLISTCOUNT_LEN);
 
 	offset = GUINT16_TO_BE(offset);
-	p = fill_apparam(p, &offset, LISTSTARTOFFSET_TAG, LISTSTARTOFFSET_LEN);
+	fill_apparam(p, &offset, LISTSTARTOFFSET_TAG, LISTSTARTOFFSET_LEN);
 
 	request = pending_request_new(pbap, message);
 
diff --git a/plugins/filesystem.c b/plugins/filesystem.c
index 677df76..e664fc5 100644
--- a/plugins/filesystem.c
+++ b/plugins/filesystem.c
@@ -604,7 +604,7 @@ ssize_t string_read(void *object, void *buf, size_t count)
 
 	len = MIN(string->len, count);
 	memcpy(buf, string->str, len);
-	string = g_string_erase(string, 0, len);
+	g_string_erase(string, 0, len);
 
 	return len;
 }
diff --git a/plugins/pbap.c b/plugins/pbap.c
index c6d7cfc..c7e792a 100644
--- a/plugins/pbap.c
+++ b/plugins/pbap.c
@@ -961,7 +961,7 @@ static ssize_t array_read(GByteArray *array, void *buf, size_t count)
 
 	len = MIN(array->len, count);
 	memcpy(buf, array->data, len);
-	array = g_byte_array_remove_range(array, 0, len);
+	g_byte_array_remove_range(array, 0, len);
 
 	return len;
 }
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux