Hi Jefferson,
* Jefferson Delfes <jefferson.delfes@xxxxxxxxxxxxx> [2012-06-04 09:31:13 -0400]:
> Hi Gustavo,
>
> On Fri, Jun 1, 2012 at 7:13 PM, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote:
> > Jefferson,
> >
> > * Jefferson Delfes <jefferson.delfes@xxxxxxxxxxxxx> [2012-06-01 15:05:25 -0400]:
> >
> >> Change flags field to matches userspace structure.
> >> This field needs to be converted to little endian before forward it.
> >>
> >> Signed-off-by: Jefferson Delfes <jefferson.delfes@xxxxxxxxxxxxx>
> >> ---
> >> include/net/bluetooth/mgmt.h | 2 +-
> >> net/bluetooth/mgmt.c | 5 +++--
> >> 2 files changed, 4 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> >> index ebfd91f..3a8a714 100644
> >> --- a/include/net/bluetooth/mgmt.h
> >> +++ b/include/net/bluetooth/mgmt.h
> >> @@ -435,7 +435,7 @@ struct mgmt_ev_auth_failed {
> >> struct mgmt_ev_device_found {
> >> struct mgmt_addr_info addr;
> >> __s8 rssi;
> >> - __u8 flags[4];
> >> + __le32 flags;
> >
> > Seems we are breaking API here, MGMT API is stable now and should have such
> > kind of change. However I wanna see what Marcel and Johan has to say about
> > this.
> >
> > Gustavo
>
> As Johan pointed, we send the same bytes in same order. This patch
> just copy userspace changes in mgmt_ev_device_found structure. There
> was a possible bug on big endian in userspace, but it was fixed in
> previous patch.
Yes, this patch don't change the order of bytes, I tried to apply it but it
failed. Please rebase on bluetooth-next and resend it.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
