Hi Andrei,
On Wed, Jun 06, 2012, Andrei Emeltchenko wrote:
> AMP controllers do not understand this command
>
> ...
> < HCI Command: Write Local Name (0x03|0x0013) plen 248
> name ''
> > HCI Event: Command Complete (0x0e) plen 4
> Write Local Name (0x03|0x0013) ncmd 1
> status 0x01
> Error: Unknown HCI Command
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> ---
> net/bluetooth/mgmt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 958f764..9afcc84 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -2135,6 +2135,9 @@ static int set_local_name(struct sock *sk, struct hci_dev *hdev, void *data,
>
> BT_DBG("");
>
> + if (hdev->amp_type != HCI_BREDR)
> + return -ENOTSUPP;
> +
> hci_dev_lock(hdev);
>
> memcpy(hdev->short_name, cp->short_name, sizeof(hdev->short_name));
This will essentially make write() fail on the mgmt socket which isn't
necessarily the most intuitive behavior (one might think there's
something wrong with the socket). What would probably make more sense is
to send a proper cmd_status reply with MGMT_STATUS_NOT_SUPPORTED.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
