Hi Gustavo,
On Thu, May 31, 2012 at 10:42 AM, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote:
> Hi Andre,
>
> * Andre Guedes <andre.guedes@xxxxxxxxxxxxx> [2012-05-30 15:08:48 -0300]:
>
>> If user tries to set an invalid MTU value, l2cap_sock_setsockopt_old
>> should return -EINVAL.
>>
>> Signed-off-by: Andre Guedes <andre.guedes@xxxxxxxxxxxxx>
>> ---
>> net/bluetooth/l2cap_sock.c | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
>> index d856cc8..a7ac747 100644
>> --- a/net/bluetooth/l2cap_sock.c
>> +++ b/net/bluetooth/l2cap_sock.c
>> @@ -445,6 +445,22 @@ static int l2cap_sock_getsockopt(struct socket *sock, int level, int optname, ch
>> return err;
>> }
>>
>> +static bool is_valid_mtu(struct l2cap_chan *chan, u16 mtu)
>
> I prefer if we call this l2cap_valid_mtu()
Ok, I'll rename it.
>> +{
>> + switch (chan->scid) {
>> + case L2CAP_CID_LE_DATA:
>> + if (mtu < L2CAP_LE_DEFAULT_MTU)
>> + return 0;
>
> If you want to return bool you might want to return false here.
>
>> + break;
>> +
>> + default:
>> + if (mtu < L2CAP_DEFAULT_MIN_MTU)
>> + return 0;
>> + }
>> +
>> + return 1;
>
> and true here.
Sure. I'll fix this.
I'll send a new version of this patch series.
BR,
Andre
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
