Hi Andrei,
* Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx> [2012-05-31 10:39:16 +0300]:
> Hi Vinicius,
>
> On Wed, May 30, 2012 at 09:20:19PM -0300, Vinicius Costa Gomes wrote:
> > Now that we have separate ways of doing connections for each link type,
> > we can do better than an "if" statement to handle each link type.
> >
> > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxxxxxx>
> > ---
> > net/bluetooth/hci_conn.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> > index 320cc5d..8848a1e 100644
> > --- a/net/bluetooth/hci_conn.c
> > +++ b/net/bluetooth/hci_conn.c
> > @@ -563,13 +563,16 @@ struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst,
> > {
> > BT_DBG("%s dst %s", hdev->name, batostr(dst));
> >
> > - if (type == LE_LINK)
> > + switch (type) {
> > + case LE_LINK:
> > return add_le_conn(hdev, dst, dst_type, sec_level, auth_type);
> > -
> > - if (type == ACL_LINK)
> > + case ACL_LINK:
> > return add_acl_conn(hdev, dst, sec_level, auth_type);
> > + case SCO_LINK:
> > + return add_sco_conn(hdev, dst, sec_level, auth_type);
>
> The patches looks OK but somehow I do not like much returns in switch.
> Some parsers will notice missing breaks which are not needed here...
Use return here seems ok to me, I just want that these functions gets a hci_
prefix.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
