Re: [PATCHv3 10/18] Bluetooth: A2MP: Process A2MP Discover Request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Fri, May 25, 2012 at 09:19:34AM -0300, Gustavo Padovan wrote:
> Hi Andrei,
> 
> > +static int a2mp_discover_req(struct amp_mgr *mgr, struct sk_buff *skb,
> > +			     struct a2mp_cmd *hdr)
> > +{
> > +	struct a2mp_discov_req *req = (struct a2mp_discov_req *) skb->data;
> 
> Just use (void *) as cast here.

This actually does not matter but I can change it. This is pity that it
was not mentioned in the 20 previous reviews ;(

> > +	rsp->mtu = cpu_to_le16(L2CAP_A2MP_DEFAULT_MTU);
> 
> __constant_cpu_to_le16() here.

OK.

Best regards 
Andrei Emeltchenko 
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux