Hi Daniel,
On 12:00 Thu 24 May, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
>
> ---
> src/hcid.h | 1 +
> src/main.c | 9 +++++++++
> src/main.conf | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/src/hcid.h b/src/hcid.h
> index 1e5e15a..2564467 100644
> --- a/src/hcid.h
> +++ b/src/hcid.h
> @@ -39,6 +39,7 @@ struct main_opts {
> gboolean name_resolv;
> gboolean debug_keys;
> gboolean gatt_enabled;
> + gboolean ignore_dun;
>
> uint8_t mode;
>
> diff --git a/src/main.c b/src/main.c
> index b062b4a..240326d 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -245,6 +245,14 @@ static void parse_config(GKeyFile *config)
> else
> main_opts.gatt_enabled = boolean;
>
> + boolean = g_key_file_get_boolean(config, "General",
> + "IgnoreDUN", &err);
> + if (err) {
> + DBG("%s", err->message);
> + g_clear_error(&err);
> + } else
> + main_opts.ignore_dun = boolean;
> +
> main_opts.link_mode = HCI_LM_ACCEPT;
>
> main_opts.link_policy = HCI_LP_RSWITCH | HCI_LP_SNIFF |
> @@ -262,6 +270,7 @@ static void init_defaults(void)
> main_opts.remember_powered = TRUE;
> main_opts.reverse_sdp = TRUE;
> main_opts.name_resolv = TRUE;
> + main_opts.ignore_dun = TRUE;
>
> if (gethostname(main_opts.host_name, sizeof(main_opts.host_name) - 1) < 0)
> strcpy(main_opts.host_name, "noname");
> diff --git a/src/main.conf b/src/main.conf
> index 787ef4f..676999d 100644
> --- a/src/main.conf
> +++ b/src/main.conf
> @@ -62,3 +62,8 @@ DebugKeys = false
>
> # Enable the GATT functionality. Default is false
> EnableGatt = false
> +
> +# If a device supports both DUN and PAN at the same time, ignore the
> +# DUN profile. Only PAN will be exposed through the D-Bus API in this
> +# case. The default is true
> +IgnoreDUN = true
I would prefer if this would be called something like "PreferPAN" (or
even "PreferPANoverDUN", but that sounds weird). I, at least, find it
easier to understand.
And I am still thinking if it would be worth considering something more
complex, that would deal with cases like this in general. But as I don't
have any concrete proposal, I will stop here.
> --
> 1.7.10.130.g36e6c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
