Hi Andrei, * Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx> [2012-05-24 12:55:53 +0300]: > Hi Gustavo, > > On Wed, May 23, 2012 at 10:12:44PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > > > > When DEFER_SETUP is set authorize() will trigger an authorization request > > to the userspace. > > Looks good. > > > +static void l2cap_sock_authorize_cb(void *data) > > +{ > > + struct sock *sk = data; > > + struct sock *parent; > > + > > + parent = bt_sk(sk)->parent; > > But why not: > > l2cap_sock_authorize_cb(struct sock *sk) > { > struct sock *parent = bt_sk(sk)->parent; We need to be generic, I said that in the other patch already. The chan->sk should disappear and the only thing l2cap_core.c will see is chan->data void * Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html