Hi, On Thu, May 24, 2012 at 12:39:59PM +0300, Andrei Emeltchenko wrote: > Hi Gustavo, > > On Wed, May 23, 2012 at 10:12:39PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > > > > This move socket specific code to l2cap_sock.c. > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > > --- > > include/net/bluetooth/l2cap.h | 1 + > > net/bluetooth/l2cap_core.c | 18 +++--------------- > > net/bluetooth/l2cap_sock.c | 21 +++++++++++++++++++++ > > 3 files changed, 25 insertions(+), 15 deletions(-) > > > > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > > index 29f7b06..d1f6819 100644 > > --- a/include/net/bluetooth/l2cap.h > > +++ b/include/net/bluetooth/l2cap.h > > @@ -530,6 +530,7 @@ struct l2cap_ops { > > void (*state_change) (void *data, int state); > > struct sk_buff *(*alloc_skb) (struct l2cap_chan *chan, > > unsigned long len, int nb); > > + void (*ready) (void *data); > > Again, why void *data ? I mean here that for fixed channels we do not need this function at this point since initialization is different. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html