Hi Vinicius, Mikel, On Wed, May 23, 2012 at 8:40 PM, Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxxxxxx> wrote: > Hi Mikel, > > On 17:00 Wed 23 May, Mikel Astiz wrote: >> From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> >> >> The number of transferred bytes is exposed in D-Bus using a specific >> property for this purpose. >> >> Internally, the value of this property does not necessarily match the >> internal progress counter. In order to avoid D-Bus overhead, the >> property will be updated at least every N bytes, where N is fixed and >> hardcoded (TRANSFER_PROGRESS_PERIOD). >> --- >> client/transfer.c | 47 +++++++++++++++++++++++++++++++++++++++++++++-- >> 1 files changed, 45 insertions(+), 2 deletions(-) >> >> diff --git a/client/transfer.c b/client/transfer.c >> index 8292265..2c6e1ed 100644 >> --- a/client/transfer.c >> +++ b/client/transfer.c >> @@ -44,6 +44,7 @@ >> >> #define TRANSFER_INTERFACE "org.openobex.Transfer" >> #define TRANSFER_BASEPATH "/org/openobex" >> +#define TRANSFER_PROGRESS_PERIOD (16 * 1024) > > Just a detail, but this value is half the value of the default Bluetooth > MTU, right? > > For a future improvement, I think it would be nice to consider a value > related to the MTU. Actually I would rather do it time based, send progress once per second, since with high speed this may spam the bus anyway. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
