Re: [PATCH BlueZ 5/5] media-api: Update documentation to include Volume property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Tue, May 22, 2012, Luiz Augusto von Dentz wrote:
> ---
>  doc/media-api.txt |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index 7a593c3..20772f0 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -341,3 +341,11 @@ Properties	object Device [readonly]
>  			Optional. Indicates where is the transport being routed
>  
>  			Possible Values: "HCI" or "PCM"
> +
> +		byte Volume [readwrite]
> +
> +			Optional. Indicates volume level of the transport,
> +			this property is only writeable when the transport was
> +			acquired by the sender.
> +
> +			Possible Values: 0-127

I'm not sure if byte is best here. I'd rather have this as an unsigned
value (the code itself looks strange too with you having to switch to
int8_t from uint8_t). Since there's no one byte unsigned D-Bus parameter
I suppose we should use uint16.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux