Hi Vinicius,
* Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxxxxxx> [2012-05-22 12:02:39 -0300]:
> Hi Gustavo,
>
> Here are some nitpicks, feel free to ignore them.
>
> On 02:40 Tue 22 May, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
>
> The title "add filter support" is not totally correct, there was some
> support for filters, but it was quite basic, right?
Quite basic, and there wasn't any option to set it from command line so I
decided to call this "add filter support"
>
> >
> > the packet code receives the data parsed from the filter file and apply
> > the proper filters to the devices.
> > ---
> > monitor/config_file.c | 4 +-
> > monitor/config_file.h | 1 +
> > monitor/main.c | 21 +++++-----
> > monitor/packet.c | 108 ++++++++++++++++++++++++++++++++++++++++---------
> > monitor/packet.h | 4 +-
> > 5 files changed, 106 insertions(+), 32 deletions(-)
> >
> > diff --git a/monitor/config_file.c b/monitor/config_file.c
> > index 6fb50f9..464fe4f 100644
> > --- a/monitor/config_file.c
> > +++ b/monitor/config_file.c
> > @@ -79,7 +79,7 @@ static struct filter_options {
> >
> > struct controller *controller;
> >
> > -static void free_controllers_list(struct list *controllers_l)
> > +void controllers_list_free(struct list *controllers_l)
>
> This change is somewhat unrelated.
Kind of, I had to export this function for this patch and I changed the name
to some that makes more sense.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
