Re: [PATCH BlueZ v0] gdbus: Fix incorrectly discarded signals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikel, Lucas,

On Tue, May 22, 2012 at 3:21 PM, Lucas De Marchi
<lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> diff --git a/gdbus/object.c b/gdbus/object.c
>> index 2dd7c0e..c33df57 100644
>> --- a/gdbus/object.c
>> +++ b/gdbus/object.c
>> @@ -616,7 +616,7 @@ static gboolean check_signal(DBusConnection *conn, const char *path,
>>                }
>>        }
>>
>> -       if (*args == NULL) {
>> +       if (!signal || !signal->name) {
>>                error("No signal named %s on interface %s", name, interface);
>>                return FALSE;
>>        }
>
>
> Ack.
>

Any reason why the code does not return TRUE within the for loop? I
think it would have been simpler that way.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux