Re: [PATCH RFC] avdtp: Fix incorrect gchar buffer allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lizardo,

On Fri, May 18, 2012, Anderson Lizardo wrote:
> The code was allocating an array of gchar pointers, where an array of
> gchar is expected.
> ---
>  audio/gstavdtpsink.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> I did not check the code at length, but looking at other functions, this is
> most likely a bug.
> 
> diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
> index af04a56..b5dfae4 100644
> --- a/audio/gstavdtpsink.c
> +++ b/audio/gstavdtpsink.c
> @@ -1144,7 +1144,7 @@ static gboolean gst_avdtp_sink_update_caps(GstAvdtpSink *self)
>  
>  static gboolean gst_avdtp_sink_get_capabilities(GstAvdtpSink *self)
>  {
> -	gchar *buf[BT_SUGGESTED_BUFFER_SIZE];
> +	gchar buf[BT_SUGGESTED_BUFFER_SIZE];
>  	struct bt_get_capabilities_req *req = (void *) buf;
>  	struct bt_get_capabilities_rsp *rsp = (void *) buf;
>  	int err;

Applied. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux