Hi Paulo, On Mon, May 21, 2012, Paulo Alcantara wrote: > + /* New format: address#type */ > + ba2str(dba, key); > + sprintf(&key[17], "#%hhu", bdaddr_type); Since BlueZ 4.100 will be the first user space version being able to use mgmtops with a kernel where mgmt is enabled by default (3.4) I don't think we need to worry about old format vs new format, i.e. the code comment above is unnecessary. > + /* New format: address#type */ > + ba2str(dba, key); > + sprintf(&key[17], "#%hhu", bdaddr_type); > + > + str = textfile_caseget(filename, key); > + if (str != NULL) > + return str; > + > + /* Old format: address only */ > + key[17] = '\0'; > + > + return textfile_caseget(filename, key); Same thing here. I think we can leave out any code that tries to work with the old storage format since we can consider LE support as experimental/unstable in all previous user space releases. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html