Re: [PATCH BlueZ 1/2] storage: Store BLE address type in "primary" file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

From: Johan Hedberg <johan.hedberg@xxxxxxxxx>
Date: Sat, 19 May 2012 09:41:24 +0300

> > +	/* New format: address#type */
> > +	ba2str(dba, key);
> > +	key[17] = '#';
> > +	key[18] = ba_type2char(bdaddr_type);
> 
> Wouldn't sprintf(&key[17], "#%hhu", bdaddr_type); be much simpler?

Agreed. Fixed it.

> > +	/* New format: address#type */
> > +	ba2str(dba, key);
> > +	key[17] = '#';
> > +	key[18] = ba_type2char(bdaddr_type);
> 
> Same here.

Fixed it too.


		Paulo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux