Hi Vani, On Mon, May 21, 2012 at 4:51 PM, Vani-dineshbhai PATEL X <vani.patel@xxxxxxxxxxxxxx> wrote: > Hi Luiz, > >> > >> > size_t avrcp_handle_vendor_reject(uint8_t *code, uint8_t *operands); >> > +void register_volume_notification ( struct avctp *session); >> > -- >> > 1.7.5.4 >> >> I had to change it completely to make it work, Im afraid you never >> really tested this as it did not compile for me, were you using >> bootstrap-configure? >> > > The code is compiling perfectly at my end and I have tested it several times with PTS before pushing it. I follow below steps to compile my code - > > autoreconf --install > ./configure --prefix=/usr --mandir=/usr/share/man --sysconfdir=/etc --localstatedir=/var --libexecdir=/lib > make > make install > > I also compiled and tested my code using bootstrap-configure by following below steps. > > ./bootstrap > ./bootstrap-configure > ./configure --prefix=/usr --mandir=/usr/share/man --sysconfdir=/etc --localstatedir=/var --libexecdir=/lib > make > make install > > Had I known that you were facing compiling issues with my code earlier, I would have published the procedure how I have been compiling the code. > It would be really nice if you could point any issues with my procedure of compiling & testing the code, so that I can adapt to the correct procedure and follow for any future updates. Don't call configure after bootstrap-configure since it is already done and you are not setting --enable-maintainer-mode, also please consider using the following in your .git/hooks/pre-commit: exec git diff --cached | ~/pathto/checkpatch.pl --no-signoff - There were not only compilation problems but a lot of code style problems as well. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
