Re: [PATCH BlueZ v5 09/13] gdbus: remove signatures from tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

>  attrib/client.c           |   12 +++++-----
>  audio/control.c           |   18 +++++++--------
>  audio/device.c            |   13 +++++------
>  audio/gateway.c           |   16 ++++++-------
>  audio/headset.c           |   55 +++++++++++++++++++++------------------------
>  audio/media.c             |    8 +++----
>  audio/sink.c              |   25 +++++++++------------
>  audio/source.c            |   14 +++++-------
>  audio/telephony-dummy.c   |   18 +++++++--------
>  audio/telephony-maemo5.c  |    2 +-
>  audio/transport.c         |   10 ++++-----
>  gdbus/gdbus.h             |    3 ---
>  gdbus/object.c            |    2 +-

you can not intermix this. I want gdbus/ patches separated.

> diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
> index 610cb19..e9e8929 100644
> --- a/gdbus/gdbus.h
> +++ b/gdbus/gdbus.h
> @@ -91,8 +91,6 @@ typedef struct {
>  
>  typedef struct {
>  	const char *name;
> -	const char *signature;
> -	const char *reply;
>  	GDBusMethodFunction function;
>  	GDBusMethodFlags flags;
>  	unsigned int privilege;
> @@ -102,7 +100,6 @@ typedef struct {
>  
>  typedef struct {
>  	const char *name;
> -	const char *signature;
>  	GDBusSignalFlags flags;
>  	const GDBusArgInfo *args;
>  } GDBusSignalTable;

instead of removing these, why don't we make them NULL and start
using .function and .flags syntax for the method/signal tables as a
first step.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux