On Fri, 20 Apr 2012 17:08:26 +0300 Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Antonio, > > On Fri, Apr 20, 2012, Antonio Ospite wrote: > > I'll add this information as a comment in the code. > > > > > > Bastien, please check if I am forgetting anything :) > > > > > > > > WHAT we need the plugin to do: > > > > > > > > - When a device is connected via USB: > > > > + Fetch the (default) adapter bdaddr (from BlueZ) and store it into > > > > the device > > > > + Fetch the device bdaddr (from the device via USB/HID) and make the > > > > device _trusted_ by the adapter (is "trusted" the correct term > > > > here? > > > > > > Setting it as trusted isn't the only thing you're doing. You're making > > > it known (meaning that you fill in details such as its SDP record, > > > including name), then adding it as trusted so that BlueZ doesn't ask the > > > user whether this device is allowed to connect. > > > > > > You need a separate function to make it "known" and insert it into > > > BlueZ's database. _set_trusted() should be a function that takes a > > > single device and a value (whether to trust or untrust), that's it. > > > > > > So you need to split it in 2 separate functions. > > > > OK, so the operations we are doing are: > > - Make the device "known" (add its details to the database of > > devices known by a given adapter) > > - Make the device trusted (enable its connection) > > > > Has the first operation a more official name? How does it relate to > > the "association" operation? Is it a device operation, in the sense > > that we are adding a device, or rather an adapter operation, in the > > sense that we are filling the database of a given adapter? > > I'd make it an adapter operation and I'd also suggest to explore the > option of using the same API that devices get added to storage during > "normal" device discovery: btd_event_device_found(). After all you are > discovering a device in this use case. The only speciality is that it > happens over USB instead of traditional Bluetooth inquiry. That way you > would only need to add the set_trusted function and nothing else. > OK, so far I've split the set_trusted() bits and moved the old big function to adapter.c, it is now called: btd_create_stored_device() I noticed than set_trusted() (i.e. writing to the trusts file) has to be called before I create the device when connected via USB, otherwise the later connection via BT does not succeed. I am still looking how to use the adapter API in btd_create_stored_device(), Scott if you are still willing to help I am sending you the latest patches privately to avoid making too much noise here for very small incremental changes. Regards, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpCrDOGPp295.pgp
Description: PGP signature
