Re: [PATCH] event: Remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paulo,

On Thu, May 10, 2012 at 8:41 PM, Paulo Alcantara
<paulo.alcantara@xxxxxxxxxxxxx> wrote:
> "srcaddr" variable is not used for anything else in
> btd_event_remote_name() function. So, remove it for now.
> ---
>  src/event.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/src/event.c b/src/event.c
> index 514744b..8ecb942 100644
> --- a/src/event.c
> +++ b/src/event.c
> @@ -318,7 +318,6 @@ void btd_event_remote_class(bdaddr_t *local, bdaddr_t *peer, uint32_t class)
>  void btd_event_remote_name(bdaddr_t *local, bdaddr_t *peer, char *name)
>  {
>        struct btd_adapter *adapter;
> -       char srcaddr[18];
>        struct btd_device *device;
>        struct remote_dev_info *dev_info;
>
> @@ -339,8 +338,6 @@ void btd_event_remote_name(bdaddr_t *local, bdaddr_t *peer, char *name)
>        if (!get_adapter_and_device(local, peer, &adapter, &device, FALSE))
>                return;
>
> -       ba2str(local, srcaddr);
> -
>        dev_info = adapter_search_found_devices(adapter, peer);
>        if (dev_info) {
>                g_free(dev_info->name);
> --
> 1.7.7.6

I believe the correct prefix here would be core, IMO event is too
generic. Other than that the patch looks good.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux