Hi Marcel, On Tue, May 8, 2012 at 11:54 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Ulisses, > >> > batostr() is not used anywhere and I don't see any reason why we should >> > keep it. Use ba2str() instead. >> > >> > Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx> >> > --- >> > include/net/bluetooth/bluetooth.h | 1 - >> > net/bluetooth/lib.c | 14 -------------- >> > 2 files changed, 15 deletions(-) >> >> The patchset looks good to me. I'm also not sure we need another >> specifier for snprintf(). >> >> Given we had static buffers instead of allocating them in the stack >> every time it'd be good to hear from Marcel if we had a reason and if >> it's still valid. IMO we don't have problems with stack usage in our >> code paths now but I haven't actually checked it. > > that code is most likely 11+ years old. It is actually not from me. So > if you wanna know why, you need to track down Max. > > Using %pM and baswap seems to be the best approach for fixing this right > now. However I am not against introducing a snprintf modifier for > Bluetooth addresses. I see. Ok, makes sense. David or Andrei? Will any of you guys send a patch? Regards, -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
