Hi Johannes,
On Mon, May 07, 2012 at 01:41:19PM +0200, Johannes Berg wrote:
> On Tue, 2012-04-24 at 16:17 +0300, Andrei Emeltchenko wrote:
>
> > --- a/include/linux/nl80211.h
> > +++ b/include/linux/nl80211.h
> > @@ -1546,6 +1546,7 @@ enum nl80211_iftype {
> > NL80211_IFTYPE_MESH_POINT,
> > NL80211_IFTYPE_P2P_CLIENT,
> > NL80211_IFTYPE_P2P_GO,
> > + NL80211_IFTYPE_BLUETOOTH_SOFTAMP,
>
> That should probably be a separate patch also updating cfg80211 (and
> maybe mac80211) where needed (at least to suppress the warnings you
> saw). Also documentation is needed.
>
> > @@ -211,6 +212,7 @@ static int ieee80211_do_open(struct net_device *dev, bool coming_up)
> > case NL80211_IFTYPE_STATION:
> > case NL80211_IFTYPE_MONITOR:
> > case NL80211_IFTYPE_ADHOC:
> > + case NL80211_IFTYPE_BLUETOOTH_SOFTAMP:
> > /* no special treatment */
> > break;
>
> You should never be able to come here with this interface type -- maybe
> make it a warning or something.
>
> > +static int vamp_send_frame(struct sk_buff *skb)
> > +{
> > + struct hci_dev *hdev = (struct hci_dev *) skb->dev;
> > + struct vamp_data *data;
> > +
> > + BT_DBG("%s", hdev->name);
> > +
> > + if (!hdev) {
> > + BT_ERR("Frame for unknown HCI device (hdev=NULL)");
> > + return -ENODEV;
> > + }
> > +
> > + if (!test_bit(HCI_RUNNING, &hdev->flags))
> > + return -EBUSY;
> > +
> > + data = hci_get_drvdata(hdev);
> > +
> > + skb_queue_tail(&data->txq, skb);
> > +
> > + schedule_work(&data->work);
>
> I don't understand the need for the asynchronous handling.
This is standard way for hci dev. Can be changed so that skb is handled
right here.
Best regards
Andrei Emeltchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
