Re: [PATCH] Bluetooth: Fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/07/2012 10:29 AM, Andrei Emeltchenko wrote:
> Hi Arend,
> 
> On Mon, May 07, 2012 at 10:21:44AM +0200, Arend van Spriel wrote:
>> On 05/07/2012 10:14 AM, Andrei Emeltchenko wrote:
>>>> They don't.  All the examples you'll find are of the form:
>>>>>
>>>>> 	if (a &&
>>>>> 	    b)
>>>>>
>>>>> not:
>>>>>
>>>>> 	if (a &&
>>>>> 			b)
>>> Actually it does not look like this, otherwise "b" would be placed in the
>>> same line, don't it?
>>
>> Let me rephrase Dave's remark so you may understand:
>>
>> 	if (a_has_to_be_long_enough_to_make_you_understand &&
>> 	    you_do_not_care_about_code_readability)
>>
>> and not:
>> 	if (a_has_to_be_long_enough_to_make_you_understand &&
>> 			you_do_not_care_about_code_readability)
> 
> You seems to forgot to reply to the main question about Codying Style.
> 
> Best regards 
> Andrei Emeltchenko 

True. But you explicitly addressed that one to David. The alignment rule
is indeed not stated in CodingStyle document, but using a seemingly
random amount of tabs is obviously not improving readability. I suppose
the alignment rule with an example could be added to the CodingStyle.

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux