Hi Syam and Johan, On 21:18 Tue 01 May, Syam Sidhardhan wrote: > Hi, > ----- Original Message ----- From: "Andre Guedes" > <andre.guedes@xxxxxxxxxxxxx> > To: "Gustavo Padovan" <gustavo@xxxxxxxxxxx>; "Syam Sidhardhan" > <s.syam@xxxxxxxxxxx>; <linux-bluetooth@xxxxxxxxxxxxxxx>; "Vinicius > Gomes" <vinicius.gomes@xxxxxxxxxxxxx> > Sent: Friday, April 20, 2012 11:43 PM > Subject: Re: [PATCH 1/5] Bluetooth: Remove unused hci_le_ltk_reply() > > > >Hi Syam/Gustavo, > > > >On Fri, Apr 13, 2012 at 7:17 PM, Gustavo Padovan > ><gustavo@xxxxxxxxxxx> wrote: > >>Hi Syam, > >> > >>* Syam Sidhardhan <s.syam@xxxxxxxxxxx> [2012-04-12 20:33:17 +0530]: > >> > >>>In this API, we were using sizeof operator for an array > >>>given as function argument, which is invalid. > >>>However this API is not used anywhere. > >>> > >>>Signed-off-by: Syam Sidhardhan <s.syam@xxxxxxxxxxx> > >>>--- > >>>include/net/bluetooth/hci_core.h | 1 - > >>>net/bluetooth/hci_conn.c | 16 ---------------- > >>>2 files changed, 0 insertions(+), 17 deletions(-) > >>> > >>>diff --git a/include/net/bluetooth/hci_core.h > >>>b/include/net/bluetooth/hci_core.h > >>>index c0b232c..6e170de 100644 > >>>--- a/include/net/bluetooth/hci_core.h > >>>+++ b/include/net/bluetooth/hci_core.h > >>>@@ -1069,7 +1069,6 @@ void hci_le_conn_update(struct hci_conn > >>>*conn, u16 min, u16 max, > >>>u16 latency, u16 to_multiplier); > >>>void hci_le_start_enc(struct hci_conn *conn, __le16 ediv, __u8 rand[8], > >>>__u8 ltk[16]); > >>>-void hci_le_ltk_reply(struct hci_conn *conn, u8 ltk[16]); > >> > >>I'll let Andre comment here, I'm not sure if this is going to be used on > >>the future or not. > > > >I'm not sure too, I think Vinicius can tell more about that. Just in case you missed what I just said on IRC: that function can be removed. > > > >Regarding the memcpy call, yes, it is definitely bogus. > > > > ping > > Regards, > Syam > Cheers, -- Vinicius -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
