Re: [PATCH obexd 1/2] client: Fix not propagating GError in session API functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Thu, Apr 26, 2012 at 5:58 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Luiz,
>
> On Thu, Apr 26, 2012, Luiz Augusto von Dentz wrote:
>> +gboolean obc_session_put(struct obc_session *session, const char *contents,
>> +                             size_t size, const char *name, GError **err)
>>  {
>>       struct obc_transfer *transfer;
>>       const char *agent;
>> @@ -1052,11 +1057,11 @@ int obc_session_put(struct obc_session *session, const char *contents,
>>       agent = obc_agent_get_name(session->agent);
>>
>>       transfer = obc_transfer_put(session->conn, agent, NULL, name, NULL,
>> -                                                     contents, size, NULL);
>> +                                             contents, size, NULL, err);
>>       if (transfer == NULL)
>>               return -EIO;
>
> This doesn't seem right. You're changing the function to return gboolean
> instead of int but yet it returns -EIO upon error?

It is obviously wrong, not sure how I missed it and the compiler
didn't complain.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux