Hi Johan, On Thu, Apr 26, 2012 at 09:42:20AM +0300, Johan Hedberg wrote: > > Perhaps the following is the correct patch (works with my device): > > > > ----------------------------------------------------------------- > > --- bluez-4.99/plugins/hciops.c.orig 2012-03-05 11:03:57.000000000 +0200 > > +++ bluez-4.99/plugins/hciops.c 2012-04-26 06:38:53.105166053 +0300 > > @@ -565,7 +565,7 @@ static void set_event_mask(int index) > > } > > > > if (dev->features[3] & LMP_RSSI_INQ) > > - events[4] |= 0x04; /* Inquiry Result with RSSI */ > > + events[4] |= 0x02; /* Inquiry Result with RSSI */ > > > > if (dev->features[5] & LMP_SNIFF_SUBR) > > events[5] |= 0x20; /* Sniff Subrating */ > > ------------------------------------------------------------------- > > > > Above the code that I quoted there's another "event[4] |= 0x02" with the comment > > "Inquiry Result with RSSI". Surely it cannot be both 0x02 and 0x04? > > The bluetooth spec 1.2 suggests 0x02 is correct. > > Yes, you're right. The correct value is 0x02 and 0x04 (which means "Read > Remote Extended Features Complete" that your dongle doesn't support). > I've pushed a patch to bluez.git to fix this and I'll also send a patch > in a minute for the kernel which will be needed when using mgmtops > instead of hciops. Can we change magic numbers to defines? Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
