Hi Johan,
On Wed, Apr 25, 2012 at 3:44 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Vishal,
>
> No top-posting! I think I've told you this already before.
>
> On Wed, Apr 25, 2012, vishal agarwal wrote:
>> In function mgmt_device_found, which is called from
>> hci_extended_inquiry_result_evt eir_append_data function is called
>> without taking care of padding bytes. I will create a new function
>> which will return the padding offset in the EIR data andit will be
>> called in function mgmt_device_found before calling the
>> eir_append_data function.
>
> That's indeed a bug but please do it in hci_extended_inquiry_result_evt
> since in the LE case the mgmt_device_found already gets the right
> parameter value and we'd be needlessly trying to find the offset for LE
> events.
I was thinking of doing it inside the
if (dev_class && !eir_has_data_type(ev->eir, eir_len, EIR_CLASS_OF_DEV)) {
}
it will help us doing it only when needed(no class of device inside EIR data).
And also in case of BLE dev_class is NULL so it will not go inside if.
and also code will be more clear.
what do you think?
>
> Johan
Vishal
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
