Re: [RFC BlueZ 1/1] core: Fix adapter mode inconsistency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikel,

On Mon, Apr 23, 2012, Mikel Astiz wrote:
> The mode change in btd_adapter_start() doesn't check if the adapter is
> discoverable, creating an inconsistency between the plugin and the core.
> 
> Using the management interface it is easy to reproduce the problem, by
> starting BlueZ while the adapter is discoverable. After this, the state
> cannot be changed.
> ---
>  src/adapter.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)

Thanks. Applied, but I really wish we could clean up and simplify this
code. Probably adapter->mode and adapter->scan_mode should be completely
removed and new connectable and discoverable boolean variables added
(since this is how the mgmt API anyway presents these settings).

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux