Hi Anderson, On Fri, Apr 20, 2012 at 11:09 PM, Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx> wrote: > Hi Hemant, > > On Thu, Apr 19, 2012 at 7:48 AM, Hemant Gupta > <hemant.gupta@xxxxxxxxxxxxxx> wrote: >> @@ -1920,13 +1920,17 @@ static void create_stored_device_from_primary(char *key, char *value, >> struct btd_adapter *adapter = user_data; >> struct btd_device *device; >> GSList *services, *uuids, *l; >> + addr_type_t addr_type; >> >> if (g_slist_find_custom(adapter->devices, >> key, (GCompareFunc) device_address_cmp)) >> return; >> >> - /* FIXME: Get the correct LE addr type (public/random) */ >> - device = device_create(connection, adapter, key, ADDR_TYPE_LE_PUBLIC); >> + sscanf(value, "%d ", &addr_type); >> + /* Increment by 2 (address type and space) */ >> + value += 2; > > I think it is a good idea to check for sscanf() return and if it > fails, assume addr_type as ADDR_TYPE_LE_PUBLIC the value as primary > data only. Remember that the system may have previously stored primary > data in the old format. > Thanks, will update this in next patch. >> + >> + device = device_create(connection, adapter, key, addr_type); >> if (!device) >> return; >> > > > Are you planning to add support for other address types in BlueZ GATT > server? It would be nice if you could share your plans on this topic. For the moment no. I was testing with Nordic device which has random device address type, and found this issue when trying to connect to nordic device again after rebooting our device. Since BlueZ creates the stored device from primary and was taking address type as Public, reconnection was not possible. > > Best Regards, > -- > Anderson Lizardo > Instituto Nokia de Tecnologia - INdT > Manaus - Brazil > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Hemant Gupta ST-Ericsson India -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
