Re: [PATCH BlueZ 3/3] device: add a btd_device_set_trusted() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Antonio,

On Mon, Feb 13, 2012, Antonio Ospite wrote:
> +int btd_device_set_trusted(const char *adapter_address,
> +			   const char *device_address,
> +			   char *name,
> +			   uint16_t vendor_id_source,
> +			   uint16_t vendor_id,
> +			   uint16_t product_id,
> +			   uint16_t version_id,
> +			   const char *uuid)
> +{

If you have a function called set_trusted then that's *all* it should
do. You have six other parameters there that have *nothing* to do with
the function name. Also, as I mentioned in my previous email the full
use case for all of these should be understood (which also implies the
code that uses them being available) before anything gets added to the
bluetoothd exported API.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux