Hi Chan-yeol,
> Sometimes BlueZ Agent is disappear suddenly or not registered
> because of agent problem. but Bluez just prints "Operation Not
> permiited"
>
> This will help debugging.
> As Marcel guided, I replace DBG with error because I can't find how to
> print out warning message
comments like this that are addressed for the reviewer, should come
after the ---
> ---
> audio/manager.c | 2 +-
> src/adapter.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/audio/manager.c b/audio/manager.c
> index aa2547c..20453e6 100644
> --- a/audio/manager.c
> +++ b/audio/manager.c
> @@ -604,7 +604,7 @@ static void hf_io_cb(GIOChannel *chan, gpointer data)
> perr = audio_device_request_authorization(device, server_uuid,
> gateway_auth_cb, device);
> if (perr < 0) {
> - DBG("Authorization denied!");
> + DBG("Authorization denied: %s", strerror(-perr));
> gateway_set_state(device, GATEWAY_STATE_DISCONNECTED);
> }
>
> diff --git a/src/adapter.c b/src/adapter.c
> index d10db10..7b83392 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -3107,6 +3107,7 @@ static int adapter_authorize(struct btd_adapter *adapter, const bdaddr_t *dst,
>
> agent = device_get_agent(device);
> if (!agent) {
> + error("Can't find device agent");
It is not really an error actually. So lets use a warning here. Since
warn() is not present you need to implement that one first.
> g_free(auth);
> return -EPERM;
> }
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
