Hi Vishal, On Fri, Apr 13, 2012, Vishal Agarwal wrote: > This patch changes the return type of function hci_persistent_key > from int to bool. > Signed-off-by: Vishal Agarwal <vishal.agarwal@xxxxxxxxxxxxxx> > --- > include/net/bluetooth/hci_core.h | 2 +- > net/bluetooth/hci_core.c | 21 +++++++++++---------- > net/bluetooth/mgmt.c | 2 +- > 3 files changed, 13 insertions(+), 12 deletions(-) I'd improve the commit message a bit. First there should be an empty line before the Signed-off-by. Secondly it's generally considered good practice to answer the question "why?" in the commit message. I.e. you could mention that it makes more sense/is more natural to use bool for this variable. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
