Hi Vishal, On Wed, Apr 11, 2012, vishal agarwal wrote: > > So I would actually prefer a cleanup patch first that changes > > hci_persistent_key() function into a bool return value. > > > > After that it could become just like this > > > > conn->temp_link_key = !persistent; > > > > As this persistent variable is also used in function mgmt_new_link_key, > which sends this value to bluez as store_hint and bluez stores the key > on the basis of this value. So this will require 2 cleanup patches, one for > bluez and one for kernel. thats what you want? No, don't change the mgmt protocol or user space. Changing mgmt_new_link_key to take bool instead of u8 as a parameter does make sense though and you could have that in the same cleanup patch as the hci_persistent_key change. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
