Re: [PATCH obexd 1/2] gobex: Introduce g_obex_abort_transfer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jaganath,

On Wed, Apr 4, 2012 at 2:11 AM, Jaganath <jaganath.k@xxxxxxxxxxx> wrote:
>
> Hi,
>
> --------------------------------------------------
> From: "Jaganath Kanakkassery" <jaganath.k@xxxxxxxxxxx>
> Sent: Tuesday, March 27, 2012 4:02 PM
> To: <linux-bluetooth@xxxxxxxxxxxxxxx>
> Cc: "Jaganath Kanakkassery" <jaganath.k@xxxxxxxxxxx>
> Subject: [PATCH obexd 1/2] gobex: Introduce g_obex_abort_transfer()
>
>
>> This function sends the abort request and wait for response before
>> disconnection. This patch fixes the issue ABORT packet not sending
>> when user cancels the transfer.
>> ---
>> gobex/gobex-transfer.c |   22 +++++++++++++++++++++-
>> gobex/gobex.c          |    4 ++--
>> gobex/gobex.h          |    4 ++++
>> 3 files changed, 27 insertions(+), 3 deletions(-)
>>
>
> Any update on this patch please?

g_obex_abort_transfer seems like a good idea, I just did not like the
idea of resetting the callback though because then we cannot tell when
remote has replied which is what Transfer.Cancel should be doing.

Btw, can you please add a unit test for this problem?


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux