Re: [PATCH obexd 1/3] MAP: Mark filter strings const

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Slawek,

On Mon, Apr 09, 2012, Slawomir Bochenski wrote:
> ---
>  plugins/messages.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

It would be good if you could get into the habit of writing proper
commit messages. One-liners are only acceptable for extremely trivial
patches and even then I wont complain if they come with more verbose
messages.

E.g. in this case I'd at a minimum be expecting something like "These
variables should be marked as const because ...". Same goes for the rest
of the patches in this set. As far as the code changes are concerned I
didn't see anything obvious that needs fixing.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux