* Andrei Emeltchenko <Andrei.Emeltchenko.news@xxxxxxxxx> [2012-03-28 16:31:33 +0300]:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
> Placeholder for future A2MP Command Reject handler.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> ---
> net/bluetooth/a2mp.c | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
> index 25d505e..745ab0c 100644
> --- a/net/bluetooth/a2mp.c
> +++ b/net/bluetooth/a2mp.c
> @@ -65,6 +65,22 @@ static void a2mp_send(struct amp_mgr *mgr, u8 code, u8 ident, u16 len,
> kfree(cmd);
> }
>
> +/* Processing A2MP messages */
> +static inline int a2mp_command_rej(struct amp_mgr *mgr, struct sk_buff *skb,
> + struct a2mp_cmd *hdr)
Remove the inline, let the compiler choose it for you.
> +{
> + struct a2mp_cmd_rej *rej = (struct a2mp_cmd_rej *) skb->data;
> +
> + if (le16_to_cpu(hdr->len) < sizeof(*rej))
Isn't != better here, if I understood correctly this has a fixed size.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
