Hi Mat, * Gustavo Padovan <gustavo@xxxxxxxxxxx> [2012-04-06 19:29:35 -0300]: > Hi Mat, > > * Mat Martineau <mathewm@xxxxxxxxxxxxxx> [2012-04-04 11:29:43 -0700]: > > > These functions encode or decode ERTM control fields (extended or > > enhanced) to or from the new l2cap_ctrl structure. > > > > Acked-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > Signed-off-by: Mat Martineau <mathewm@xxxxxxxxxxxxxx> > > --- > > net/bluetooth/l2cap_core.c | 99 ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > Both patches were applied to bluetooth-next. thanks. net/bluetooth/l2cap_core.c:317:12: warning: ‘l2cap_seq_list_pop’ defined but not used [-Wunused-function] net/bluetooth/l2cap_core.c:323:13: warning: ‘l2cap_seq_list_clear’ defined but not used [-Wunused-function] net/bluetooth/l2cap_core.c:335:13: warning: ‘l2cap_seq_list_append’ defined but not used [-Wunused-function] net/bluetooth/l2cap_core.c:780:12: warning: ‘__pack_enhanced_control’ defined but not used [-Wunused-function] net/bluetooth/l2cap_core.c:823:12: warning: ‘__pack_extended_control’ defined but not used [-Wunused-function] So, this is not good, we can't just throw unused code here, they will generate warnings and I'll get complains from maintainers above me if I merge this. Both patches were reverted. Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
