Hi Claudio, On Wed, Apr 04, 2012, Claudio Takahasi wrote: > @@ -714,6 +717,9 @@ static gboolean parse_set_opts(struct set_opts *opts, GError **err, > case BT_IO_OPT_DEST_BDADDR: > bacpy(&opts->dst, va_arg(args, const bdaddr_t *)); > break; > + case BT_IO_OPT_DEST_TYPE: > + opts->dst_type = va_arg(args, int); > + break; > case BT_IO_OPT_DEFER_TIMEOUT: > opts->defer = va_arg(args, int); > break; I'd prefer that you also add a line to the "Set defaults" section of this function to initialize opts->dst_type (I know the default is implicitly 0 but it's good to have it there for clarity). Also, are you planning to add BT_IO_* defines/enum for the types or what value is the new BtIO API expecting to receive (this should probably be documented and you do need to know the answer to the question before adding the initialization line I requested). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
