On 04/04/2012 01:10 PM, Johan Hedberg wrote:
On Wed, Apr 04, 2012, Johan Hedberg wrote:
Hi Rafal,
On Wed, Apr 04, 2012, Garbat Rafal wrote:
The patch looks ok'ish but it doesn't compile:
audio/avdtp.c: In function ‘avdtp_parse_rej’:
audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
Secondly, please use a "avdtp:" prefix for the commit message
("Bluetooth" is only reserved for kernel patches) and remove the '.'
>from the end of the summary line.
Johan
Sorry, just a nasty typo. Will fix it and send patch once again.
The thing I'm more worried about is that this seems to imply that you've
neither run the code nor even tried to compile it. Is that the case?
I.e. how do you know that the patch is correct if you haven't tested it?
Johan
It was tested (special use case with one of the carkits we had) and I
did this typo when I was porting
this from the other project. Sorry, it was done in a hurry.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
