On Mon, Apr 2, 2012 at 17:55, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Arik, > > On Mon, Apr 02, 2012, Arik Nemtsov wrote: >> --- a/proximity/reporter.c >> +++ b/proximity/reporter.c >> @@ -40,6 +40,7 @@ >> #include "attrib-server.h" >> #include "reporter.h" >> >> +static DBusConnection *connection; >> #define IMMEDIATE_ALERT_SVC_UUID 0x1802 >> #define LINK_LOSS_SVC_UUID 0x1803 >> #define TX_POWER_SVC_UUID 0x1804 > > Please move the new static variable after the defines and the enum. > Thats's usually where we place them (right before the actual functions > start). > Well this variable disappears in the patch "proximity: reporter: implement D-Bus API", where we start saving the D-Bus connection per reporter_adapter. So I'm guessing this is moot? Arik -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
