Re: [PATCH v7 1/6] att: add remote btd_device to ATT read/write callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arik,

On Mon, Apr 02, 2012, Arik Nemtsov wrote:
> +	uint8_t (*read_cb)(struct attribute *a, struct btd_device *device,
> +			   gpointer user_data);
> +	uint8_t (*write_cb)(struct attribute *a, struct btd_device *device,
> +			    gpointer user_data);

Please don't mix tabs and spaces for indentation. We only use tabs.

> @@ -452,7 +457,8 @@ static uint16_t read_by_group(struct gatt_channel *channel, uint16_t start,
>  								a->read_reqs);
>  
>  		if (status == 0x00 && a->read_cb)
> -			status = a->read_cb(a, a->cb_user_data);
> +			status = a->read_cb(a, channel->device,
> +					    a->cb_user_data);

Same here.

> @@ -541,7 +547,8 @@ static uint16_t read_by_type(struct gatt_channel *channel, uint16_t start,
>  								a->read_reqs);
>  
>  		if (status == 0x00 && a->read_cb)
> -			status = a->read_cb(a, a->cb_user_data);
> +			status = a->read_cb(a, channel->device,
> +					    a->cb_user_data);

And here.

> @@ -833,7 +840,8 @@ static uint16_t write_value(struct gatt_channel *channel, uint16_t handle,
>  							value, vlen, NULL);
>  
>  		if (a->write_cb) {
> -			status = a->write_cb(a, a->cb_user_data);
> +			status = a->write_cb(a, channel->device,
> +					     a->cb_user_data);

And here.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux