Re: [RFC 3/3] Bluetooth: Use address type info from User-space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Wed, Mar 28, 2012 at 11:26 AM, Andrei Emeltchenko
<andrei.emeltchenko.news@xxxxxxxxx> wrote:
> Hi Andre,
>
> On Wed, Mar 28, 2012 at 11:05:47AM -0300, Andre Guedes wrote:
>> >> -int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, bdaddr_t *dst)
>> >> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
>> >> +                     bdaddr_t *dst, u8 dst_type)
>> >>  {
>> >>       struct sock *sk = chan->sk;
>> >>       bdaddr_t *src = &bt_sk(sk)->src;
>> >> @@ -1141,8 +1142,8 @@ int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, bdaddr_t *d
>> >>       __u8 auth_type;
>> >>       int err;
>> >>
>> >> -     BT_DBG("%s -> %s psm 0x%2.2x", batostr(src), batostr(dst),
>> >> -                                             __le16_to_cpu(chan->psm));
>> >> +     BT_DBG("%s -> %s (type %u) psm 0x%2.2x", batostr(src), batostr(dst),
>> >> +                                     dst_type, __le16_to_cpu(chan->psm));
>> >
>> > If you change style for other functions you might change it here as well.
>>
>> Sorry, didn't follow you here.
>
> In l2cap_chan_connect you seems align second line at "(". Maybe we need
> then align the same for debug statement?

I see now, I guess we are supposed to align debug too. I'll fix this.

Thanks,

Andre
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux