Re: [RFC 2/8] HoG: register ATTIO callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi João,

On Wed, Mar 28, 2012 at 10:55:18AM -0300, Joao Paulo Rechi Vita wrote:
> Hello Andrei,
> 
> 2012/3/28 Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx>:
> > Hi João,
> >
> > Minor comments:
> >
> > On Tue, Mar 27, 2012 at 07:31:21PM -0300, João Paulo Rechi Vita wrote:
> > ...
> >> +static struct hog_device *hog_device_new(struct btd_device *device,
> >> +                                                     const char *path)
> >> +{
> > ...
> >> +
> >> +     hogdev->attioid = btd_device_add_attio_callback(device,
> >> +                                                     attio_connected_cb,
> >> +                                                     attio_disconnected_cb,
> >> +                                                     hogdev);
> >
> > What is the coding style for the userspace? Shall it be at least the same?
> >
> 
> Unless something has changed lately we use the kernel coding style. I
> don't see where I didn't follow it here, but I may be missing
> something. Can you please point me what I'm missing if that is the
> case?

I mean are those parameters aligned to the right or at "(".

Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux